Update role.yaml to allow queries on ingressclasses #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updated jaeger-operator is querying the cluster to know informations about ingressclasses. But the role created by the jaeger-operator helm chart doesn't allow get or list on ingressclasses. This change addresses that. Fixes jaegertracing#549 Signed-off-by: Mathieu Bouchard <[email protected]>
viccuad
approved these changes
Jul 29, 2024
|
This issue is blocking me for a while now. When can this PR be merged with main and added to a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated jaeger-operator is querying the cluster to know informations about ingressclasses. But the role created by the jaeger-operator helm chart doesn't allow get or list on ingressclasses.
This change addresses that.
What this PR does
Which issue this PR fixes